Expose builder-like interface for path verification#486
Open
Conversation
djc
commented
May 3, 2026
| // Use `'a` for lifetimes that we don't care about, `'p` for lifetimes that become a part of | ||
| // the `VerifiedPath`. | ||
| pub(crate) struct ChainOptions<'a, 'p> { | ||
| pub(crate) struct PathBuilder<'a, 'p> { |
Member
Author
There was a problem hiding this comment.
Not sure this is the best name? I wanted to evoke "path building" but maybe that's too jargony and it would be better to stick with "verification" or "verifier" language.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 96.97% 96.99% +0.02%
==========================================
Files 20 20
Lines 3936 3933 -3
==========================================
- Hits 3817 3815 -2
+ Misses 119 118 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the many-argument
verify_for_usage()complexity bottleneck in favor of exposing the underlyingChainOptionsdirectly (under a different name). Should make it easier to evolve this API going forward (as suggested in #485).